[HOLD for payment 2022-05-20] Wrong welcome message for deleted #admins/#announce rooms - Reported by @thesahindia

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Create a new workspace
2. Navigate to #admins or #announce rooms
3. Delete Workspace
4. Check room Welcome message

Expected Result:

There should be clear welcome message if workspace and room are deleted

Actual Result:

the following message displayed
"This is the beginning of the private #admins (deleted) room, invite others by @mentioning them."

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @thesahindia
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1643304400108500

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @mateocole (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[thesahindia]

Proposal

We can add a function in ReportWelcomeText.js which will return welcome text for rooms based on ReportUtils.isArchivedRoom(props.report)
if ReportUtils.isArchivedRoom(props.report) is true we will show the welcome text for deleted room and if it's false we will show the welcome text that we are showing currently.

const roomWelcomeText = () => (ReportUtils.isArchivedRoom(props.report)
        ? (
            <>
                <Text>
                    {props.translate('reportActionsView.deletedRoomTextPartOne')}
                </Text>
                <Text style={[styles.textStrong]}>
                    {lodashGet(chatUsers, '[0].displayName', '')}
                </Text>
                <Text>
                    {props.translate('reportActionsView.deletedRoomTextPartTwo')}
                </Text>
            </>
        ) : (
            <>
                <Text>
                    {isResctrictedRoom
                        ? `${props.translate('reportActionsView.beginningOfChatHistoryRestrictedPartOne')}`
                        : `${props.translate('reportActionsView.beginningOfChatHistoryPrivatePartOne')}`}
                </Text>
                <Text style={[styles.textStrong]}>
                    {lodashGet(chatUsers, '[0].displayName', '')}
                </Text>
                <Text>
                    {isResctrictedRoom
                        ? `${props.translate('reportActionsView.beginningOfChatHistoryRestrictedPartTwo')}`
                        : `${props.translate('reportActionsView.beginningOfChatHistoryPrivatePartTwo')}`}
                </Text>
            </>
        ));

We need to remove the code below and need to add roomWelcomeText()

return (
        <Text style={[styles.mt3, styles.textAlignCenter]}>
            {!props.shouldIncludeParticipants
                ? (
-                   <>
-                      <Text>
-                            {isResctrictedRoom
-                                ? `${props.translate('reportActionsView.beginningOfChatHistoryRestrictedPartOne')}`
-                                : `${props.translate('reportActionsView.beginningOfChatHistoryPrivatePartOne')}`}
-                        </Text>
-                        <Text style={[styles.textStrong]}>
-                            {lodashGet(chatUsers, '[0].displayName', '')}
-                        </Text>
-                        <Text>
-                            {isResctrictedRoom
-                                ? `${props.translate('reportActionsView.beginningOfChatHistoryRestrictedPartTwo')}`
-                                : `${props.translate('reportActionsView.beginningOfChatHistoryPrivatePartTwo')}`}
-                        </Text>
-                    </>
+                         roomWelcomeText()
                ) : (
                    <>
                        <Text>
                            {props.translate('reportActionsView.beginningOfChatHistory')}
                        </Text>
                        {_.map(chatUsers, ({displayName, pronouns}, index) => (
                            <Text key={displayName}>
                                <Text style={[styles.textStrong]}>
                                    {displayName}
                                </Text>
                                {!_.isEmpty(pronouns) && <Text>{` (${pronouns})`}</Text>}
                                {(index === chatUsers.length - 1) && <Text>.</Text>}
                                {(index === chatUsers.length - 2) && <Text>{` ${props.translate('common.and')} `}</Text>}
                                {(index < chatUsers.length - 2) && <Text>, </Text>}
                            </Text>
                        ))}
                    </>
                )}
        </Text>

[MelvinBot]

@mateocole Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@mateocole Still overdue 6 days?! Let's take care of this!

[MelvinBot]

@mateocole 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mateocole]

By design, if a room is deleted we will still want to maintain all conversation in this room and leave it as is.

To clarify, are you saying the expected result for a deleted room with no chat history should say something like "nothing to see here" if there was no chat history?

[thesahindia]

@mateocole, I meant we should show a different message for deleted rooms currently it says "This is the beginning of the private #announce (deleted) room, invite others by @mentioning them." But we can't invite anyone in the deleted room.

[mateocole]

Got so to clarify to the engineer reviewing:

In the case the room has 0 chat history, perhaps we can allow for deletion of the room. If there is chat history retain that.

Or option B, we leave the room, but change the text.

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MariaHCD]

Changing the message for deleted rooms sounds good to me. What copy would work here, @mateocole? Maybe something like: "This is the beginning of #admins (deleted), there's nothing to see here."?

[MelvinBot]

Triggered auto assignment to @bfitzexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[bfitzexpensify]

Upwork posting here.

I think the copy @MariaHCD shared makes sense.

[bfitzexpensify]

Hey @thesahindia - no regressions yet, so just getting everything in order to pay this out. I've invited you to a new Upwork job (the old one had expired). I've set it for $750 - reporting bonus, work completed, and a patience bonus 😄. Please accept the job there and I'll pay out on the 20th - thanks!

[thesahindia]

Cool, I have accepted the offer. Thanks.

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[bfitzexpensify]

Having trouble paying this out - getting an error from Upwork trying to end the contract. It's implied that it is a temporary error, so reassigning for this to be tried to pay out later today (PST).

[JmillsExpensify]

I've successfully issued payment to @thesahindia. @rushatgabhane have you been paid out for C+ yet? I'll leave the issue open until we confirm.

[rushatgabhane]

@JmillsExpensify nope, thanks for confirming

[JmillsExpensify]

Great, I just stepped out but I'll pay this when I return to the office a bit later today.

[thesahindia]

Hi @JmillsExpensify, looks like I was paid $1500 instead of $750, can you look into that as well?

[JmillsExpensify]

Oh weird.

[JmillsExpensify]

Cool, checked into it. It looks like we have two milestones created for the project, and a project price of $750 each. @thesahindia I've asked for a refund of the additional $750 via Upwork, thanks!

[thesahindia]

Done 🚀 Refunded.

[JmillsExpensify]

@rushatgabhane Invited you to the Upwork job. Mind accepting, so I can pay you and then we'll close this out?

[rushatgabhane]

@JmillsExpensify I think the comp for C+ is $500. So I'm gonna accept the offer with the modified amount of $500.

@thesahindia received additional $250 for reporting the issue.

Please correct me if I'm wrong

[bfitzexpensify]

Correct @rushatgabhane - just sent the offer to you now.

[bfitzexpensify]

Hey @rushatgabhane - just letting you know I'm chatting to Upwork support about this payment, I'm getting an error when trying to pay out. Once it's resolved, I'll let you know and finalise it, hopefully in the next day or two! Thanks for your understanding.

[rushatgabhane]

No worries, please take as long as it needs. Thanks for letting me know!

[bfitzexpensify]

OK, all sorted! Paid you @rushatgabhane - thanks for your understanding here, really appreciate it.