Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace name is not shown in the modal header for connect to bank account #8175

Closed
kavimuru opened this issue Mar 16, 2022 · 6 comments
Closed
Assignees

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #8065

Action Performed:

  1. Go staging.new.expensify.com and login
  2. Go to workspace > bank account

Expected Result:

Verify that the workspace name is shown in the modal header.

Actual Result:

Workspace name is not shown in the modal header.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.43-1
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature
Email or phone of affected tester (no customers): applausetester++2501mn@applause.expensifail.com / Utest123
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5492431_Screenshot__248_ (1)

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Mar 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mollfpr
Copy link
Contributor

mollfpr commented Mar 16, 2022

  1. I think it makes sense because a connecting bank account is for the account not for the workspace
  2. There's no policy ID applied in the route so there's no way our hoc withFullPolicy will give the workspace data

@luacmartins
Copy link
Contributor

I can take a look at this one @tylerkaraszewski!

@luacmartins luacmartins self-assigned this Mar 16, 2022
@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 16, 2022
@luacmartins
Copy link
Contributor

Removing the deploy blocker label since this feature is still a WIP.

@tylerkaraszewski
Copy link
Contributor

This is not really an issue, the test steps just include an extra line that they shouldn't. I'll remove that line from the tests steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants