Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a free policy on OldDot doesn't navigate to the workspace #8676

Closed
neil-marcellini opened this issue Apr 18, 2022 · 4 comments
Closed
Assignees
Labels
Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@neil-marcellini
Copy link
Contributor

Action Performed:

  1. Sign into OldDot with an account A
  2. Create a free policy / workspace if you don't have one already
  3. Sign into NewDot with a different account B
  4. Go back to OldDot and click on the name of the free policy

Expected Result:

NewDot should open in a new tab and the workspace / free policy should be open in the RHN

Actual Result:

The expected result happens, but then the page loads again and the user is navigated back to the home screen.

Workaround:

Open the settings and go to the workspace.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.54-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @neil-marcellini
Slack conversation:

View all open jobs on GitHub

@neil-marcellini
Copy link
Contributor Author

That Onyx PR above will hopefully fix this issue. After it is merged I will update the onyx version.

@neil-marcellini neil-marcellini added the Reviewing Has a PR in review label Apr 21, 2022
@neil-marcellini
Copy link
Contributor Author

neil-marcellini commented Apr 21, 2022

From the feedback on my Onyx PR I gathered that it might be more simple to wait for Onyx to finish clearing before signing the new user in, so I'll put up a PR for that. I still think that the Onyx solution is better, but I'll leave it up to the reviewers to decide which solution to merge.

@melvin-bot
Copy link

melvin-bot bot commented May 16, 2022

This issue has not been updated in over 15 days. @neil-marcellini eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 16, 2022
@neil-marcellini
Copy link
Contributor Author

Let me put it back to weekly. I'm still actively working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant