Chat search should prioritise a perfectly matching email above a partially matching one

[Julesssss]

Action Performed:

• Have some accounts with similar names, in my case user2@expensify.com & newuser2@expensify.com
• Sign in to two accounts, in my case user7@expensify.com & user2@expensify.com
• As one user, attempt to search for the other, using their EMAIL ADDRESS
• Enter the full emal address and hit enter

Expected Result:

• I would expect the first result to be the user which matches the email

Actual Result:

• A completely different user chat was opened, one which is similarly named

Workaround:

• Manually select the user which matches the email search

NewDot-SearchShouldPrioritiseFullMatches.mov

Platform:

• Web
• Desktop App

Version Number: v1.1.56-0
Reproducible in staging?: Yep
Reproducible in production?: Yep
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856 N/A
Notes/Photos/Videos: See above
Expensify/Expensify Issue URL: N/A
Issue reported by: @Julesssss
Slack conversation: N/A

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[melvin-bot]

Current assignee @Julesssss is eligible for the Engineering assigner, not assigning anyone new.

[laurenreidexpensify]

@Julesssss wanna apply the rest of the labels to get this on upwork? add external and we're in business

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[Julesssss]

Out of interest Lauren, how come you unassigned yourself? Auto-assigner would have kept you on in that case right? Like it did for me

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1519120845909348352/job-details
External - https://www.upwork.com/jobs/~01b2bf4a3d7570d604

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Current assignee @Julesssss is eligible for the Exported assigner, not assigning anyone new.

[tgolen]

I'm actually gonna grab this and work on it myself

[Julesssss]

Nice, thanks Tim. I honestly wasn't sure if this was worth fixing. But it will inevitably catch users out so let's get it resolved.

Feel free to tag me as a reviewer!

[tgolen]

Thanks @Julesssss!

I'm having some issues reproducing the issue. I created three users:

• user1@expensify.com - nothing except "user1"
• newuser1@expensify.com - something before "user1"
• user10@expensify.com - something after "user1"

When I search for "user1@" it selects the correct person:

When I search for "newuser1@" it also selects the correct person:

It appears to be working correctly, but maybe there is something specific about your setup that is causing the issue you're seeing. Do you think you could help me narrow down the exact case to reproduce this?

[Julesssss]

Ah curious. I'll take another look at my env first thing tomorrow morning and get back to you. It's even more of an edge case than I originally thought :D

[jliexpensify]

Cancelling Upworks job.

[Julesssss]

@tgolen

I tried again today and noticed that newuser2@... was showing above user2@ because I had sent messages to that user recently. I still think there's an argument that a literal email match should take priority over recent chat history, but I'll leave it up to you to decide whether this is worth changing.

[tgolen]

Aha! Maybe there is something there. I see we are setting sortByLastMessageTimestamp: false, when doing a search, so I will look into that a little more.

[tgolen]

Yep, I was able to reproduce it after having a recent message sent to newuser1@expensify.com:

Looking into it more.