[HOLD for payment 2022-05-20] [$250] Web - Using Ctrl C and Ctrl V commands does not work for copy multiple messages

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing PR: #8743

Action Performed:

1. Open app
2. Send messages with any bold, italic style words
3. Copy multiple messages using command Ctrl C
4. Past message using command Ctrl V

Expected Result:

Message format should be the same the you use Ctrl C and Ctrl V commands

Actual Result:

Using Ctrl C and Ctrl V commands does not keep formating when copying multiple messages

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.57.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): applausetester+31622@applause.expensifail.com/ Qwerty123

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5547921_copy.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @kadiealexander (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[joelbettner]

This sounds like it is worth being worked on if you know a good solution.

[kadiealexander]

Upwork job posted!
https://www.upwork.com/jobs/~01a78042b40c3a1871
https://www.upwork.com/ab/applicants/1519152217793363968/job-details

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Triggered auto assignment to @iwiznia (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[b1tjoy]

Reason

Because this line raise an exception when we use Ctrl C command:

App/src/libs/SelectionScraper/index.js

Line 94 in 9bf9128

dom.setAttribute('data', Str.htmlEncode(dom.data));

The exception is "dom.setAttribute is not a function".

Solution

Merge pull #8741 will fix this issue.

[ahmdshrif]

looks to work fine now on main after merge @b1tjoy PR

[mananjadhav]

Thanks for the comments @b1tjoy and @ahmdshrif. @kbecciv Can you also test once if you can still reproduce this?

[kadiealexander]

@kbecciv could you please let us know if this is reproducible?

[kbecciv]

@kadiealexander Issue is still reproduced.

Recording.364.mp4

[ahmdshrif]

#8741 (comment)
Just mention that PR not deploy to stage yet .. but can be tested on main branch.

[mvtglobally]

Issue not reproducible during KI retests. (First week)