Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$2000] App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel #8888

Closed
mvtglobally opened this issue May 6, 2022 · 66 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@mvtglobally
Copy link

mvtglobally commented May 6, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Git clone, npm install, npm run web

Expected Result:

App runs without invalid hook call JavaScript error.

Actual Result:

Browser window opens and remains blank, and there’s an invalid hook call... error in the JavaScript console.

There do appear to be invalid hook calls in react-native-safe-area-context in SafeAreaContext.tsx.

Workaround:

Using an old node/npm version (e.g. 14.9.0/6.14.8) resolves the issue.

Platform:

Where is this issue occurring?

  • Desktop App

Version Number: 1.1.56-0
Reproducible in staging?: need repro
Reproducible in production?: need repro
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
expensify_m1_issue_1

Expensify/Expensify Issue URL:
Issue reported by: @ David Frenkiel
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1650494818552169?thread_ts=1650471398.505469&cid=C01GTK53T8Q

Job Post: https://www.upwork.com/jobs/~01570a3972089306b9

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

Not running an M1 mac so can't properly test this.

@marcaaron marcaaron added Weekly KSv2 Daily KSv2 Improvement Item broken or needs improvement. and removed Daily KSv2 Weekly KSv2 labels May 6, 2022
@marcaaron marcaaron removed their assignment May 6, 2022
@marcaaron marcaaron added the External Added to denote the issue can be worked on by a contributor label May 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels May 6, 2022
@JediWattson
Copy link
Contributor

I just wanted to point out that I'm having the issue on an i5 intel macbook, so I don't think it's specific to m1

Also I wanted to share if you run "npm install" after the initial install you'll get this error.
This install was run using:
node v18.0.0
npm v8.6.0

Screen Shot 2022-05-06 at 8 23 44 PM

@muas19
Copy link

muas19 commented May 7, 2022

This issue affects not only m1 macbooks.

@melvin-bot melvin-bot bot added the Overdue label May 9, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 9, 2022

@kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@kevinksullivan kevinksullivan changed the title App fails on Apple M1 device using recent node/npm with JavaScript error - reported by David Frenkiel App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel May 11, 2022
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels May 11, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 11, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jul 4, 2022
@Santhosh-Sellavel
Copy link
Collaborator

Kindly bump this down to weekly while we wait for new/updated proposals, thanks!
@AndrewGable @kevinksullivan

@melvin-bot melvin-bot bot added the Overdue label Jul 6, 2022
@kevinksullivan kevinksullivan added Weekly KSv2 and removed Daily KSv2 labels Jul 6, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jul 6, 2022
@kevinksullivan
Copy link
Contributor

@parasharrajat sorry I didn't see the issue you're referring to. Can you let me know if you're able to find it if we think it'll include valuable context?

@parasharrajat
Copy link
Member

Sorry @kevinksullivan, I am not sure which issue are you referring to.

@kevinksullivan
Copy link
Contributor

Ah, wrong issue. Disregard.

@kevinksullivan
Copy link
Contributor

Still waiting on proposals, updating the price.

@melvin-bot melvin-bot bot removed the Overdue label Jul 15, 2022
@kevinksullivan kevinksullivan changed the title [$500] App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel [$1000] App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel Jul 15, 2022
@melvin-bot melvin-bot bot added the Overdue label Jul 25, 2022
@kevinksullivan
Copy link
Contributor

Price doubled.

@melvin-bot melvin-bot bot removed the Overdue label Jul 27, 2022
@kevinksullivan kevinksullivan changed the title [$1000] App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel [$2000] App fails on devices using recent node/npm with JavaScript error - reported by David Frenkiel Jul 27, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 5, 2022
@AndrewGable
Copy link
Contributor

I think we are actually working on this one internally and might be able to close this

@kevinksullivan
Copy link
Contributor

@frenkield can you apply for the job so I can pay the reporting bonus? i'm not having any luck with Upwork search.

https://www.upwork.com/jobs/~01570a3972089306b9

@frenkield
Copy link
Contributor

Thanks, @kevinksullivan. I just applied.

@kevinksullivan
Copy link
Contributor

Hired! Mind accepting and then I can pay this out @frenkield ?

@frenkield
Copy link
Contributor

All set, @kevinksullivan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests