Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments -Two options are hidden when you click on > button #8922

Closed
kbecciv opened this issue May 10, 2022 · 8 comments
Closed

Payments -Two options are hidden when you click on > button #8922

kbecciv opened this issue May 10, 2022 · 8 comments
Assignees
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented May 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify,com
  2. Log in with any account
  3. Go to Profile - Settings
  4. Select Payments
  5. Click on > button

Expected Result:

Two options are visible when you click on > button

Actual Result:

Two options are hidden when you click on > button

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.376.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 10, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2022

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@NikkiWines
Copy link
Contributor

NikkiWines commented May 10, 2022

Yeah, this is weird. Marking as external! Nvm it's a deploy blocker, looking into this!

@NikkiWines
Copy link
Contributor

I think it's because of #8609. cc: @parasharrajat @thesahindia

I checked out the commit directly prior to the merge commit and it worked as expected:
image

@NikkiWines
Copy link
Contributor

I'm not sure how to fix this off the top of my head and I'm OOO for most of today, so let's revert for now and re-introduce it with this edge case accounted for.

@thesahindia
Copy link
Member

@NikkiWines, I had mentioned about this in #8609 (comment)
To get more info about this issue you can check this #7985 (comment)

@NikkiWines
Copy link
Contributor

Ah, I must have missed that - thank you for the context @thesahindia.

If there's already a potential fix in the works I think in this case then it is ok to remove the deploy blocker label. Let's make sure to test this case in that PR as well. cc: @Julesssss since you just self-assigned #7985

@NikkiWines NikkiWines added Weekly KSv2 Hourly KSv2 Improvement Item broken or needs improvement. and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Weekly KSv2 labels May 10, 2022
@melvin-bot melvin-bot bot added the Overdue label May 18, 2022
@NikkiWines
Copy link
Contributor

Oh oops, we can close this since the bug will be handed in #7985

@melvin-bot melvin-bot bot removed the Overdue label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Improvement Item broken or needs improvement. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants