Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending money - User can't search for a currency because the search function is blocked #8926

Closed
kbecciv opened this issue May 10, 2022 · 10 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented May 10, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.expensify.com
  2. Log into a verified user
  3. Search for any user and open a chat
  4. Click on the "Plus" icon
  5. Click on "Send Money"
  6. Click on the "Currency symbol"
  7. In the search bar, attempt to write something

Expected Result:

The user expects to be able to search for his/her desired currency

Actual Result:

The search toggle is completely blocked and the user is forced to scroll through the currencies to try and find the correct one

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web
    -IOS

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5566251_Cant_search.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 10, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 10, 2022

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

Looks like this is reproducible on dev as well and does not happen on production.

@chiragsalian
Copy link
Contributor

chiragsalian commented May 11, 2022

I suspect this PR - https://github.com/Expensify/App/pull/8591/files
Edit: Reverting the PR's code seems to have resolved the issue. Now diving into what the PR was meant to solve.

@chiragsalian
Copy link
Contributor

Cool looks like the issue is because the code is calling onBlur. So when the currency icon is clicked here,
image

The onblur gets called and is locking focus to the currency numbers which is why we can't type anything here,
image

Okay i'll just revert the offending PR and let them know about it.

@chiragsalian
Copy link
Contributor

This should be resolved in version 1.1.57-14 or higher.
@kbecciv, can you retest and if it passes then remove deployBlocker and check if off the checklist? 🙇‍♂️

@Julesssss
Copy link
Contributor

@chiragsalianthe the reverted PR fixed a valid issue so we'll need to ensure it gets resolved with a modified proposal. I posted in the issue to let them know

@Beamanator
Copy link
Contributor

Thanks for investigating & reverting - can this issue now be closed?

@Julesssss
Copy link
Contributor

I think we're just awaiting @Expensify/applause testing

@chiragsalian
Copy link
Contributor

QA mentioned it was tested. removing deploy blocker label. Actually yeah i'll close these as well since there is no reason to continue seeing them and it takes a while to go to prod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants