Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Styling on FullPageOfflineBlockingView #9268

Closed
Luke9389 opened this issue Jun 1, 2022 · 5 comments
Closed

Fix Styling on FullPageOfflineBlockingView #9268

Luke9389 opened this issue Jun 1, 2022 · 5 comments
Assignees
@Luke9389
Labels
Daily KSv2 Improvement Item broken or needs improvement.

Comments

@Luke9389
Copy link
Contributor

Luke9389 commented Jun 1, 2022

@shawnborton

We created the <FullPageOfflineBlockingView last Friday in a hurry to unblock other N07 PRs and initiatives. There are some styling problems that @shawnborton brought up on that PR that need to be fixed.

"the icon dimensions should be 60x60 and not 50x50. There should be 20px margin below the icon. The heading that says "You appear to be offline" does not need a period and it should use the same font size as our page headers do (17px)"
@Luke9389 Luke9389 added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Jun 1, 2022
@Luke9389 Luke9389 self-assigned this Jun 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2022

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@melvin-bot melvin-bot bot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Jun 1, 2022
@Luke9389
Copy link
Contributor Author

Luke9389 commented Jun 1, 2022

Sorry about the noise @zanyrenney, I'm gonna do this one myself.

@Luke9389 Luke9389 mentioned this issue Jun 1, 2022
Merged
@Luke9389 Luke9389 added the Improvement Item broken or needs improvement. label Jun 1, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2022

@Luke9389 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jun 6, 2022

@Luke9389 Eep! 4 days overdue now. Issues have feelings too...

@Luke9389
Copy link
Contributor Author

Luke9389 commented Jun 7, 2022

this was merged. not sure why the issue wasn't closed.

@Luke9389 Luke9389 closed this as completed Jun 7, 2022
@melvin-bot melvin-bot bot removed the Overdue label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luke9389 Luke9389

Labels
Daily KSv2 Improvement Item broken or needs improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Luke9389 @zanyrenney