Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Middle content is incorrect for the archived workspace chat #9365

Closed
kbecciv opened this issue Jun 8, 2022 · 6 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.

Comments

@kbecciv
Copy link

kbecciv commented Jun 8, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when execute PR: #8569

Action Performed:

  1. Launch the app
  2. Log into an account that has defaultRooms, UserCreatedPolicyRooms, and Workspace Chats (policyExpenseChats).
  3. Go to each type of chat (including DM's and group DMs too) and verify that that the chat name looks correct in the LHN, the header, the report welcome text.

Expected Result:

Middle text should start with "Collaboration between ..."for the archived workspace chat

Actual Result:

Middle content is incorrect for the archived workspace chat

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.74.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): expensifail accounts

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screenshot_20220608-141158_New Expensify (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause- Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 8, 2022

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@neil-marcellini
Copy link
Contributor

By "middle text" do you mean the welcome message under the icon? What do you think it should say instead? See this comment, I believe this change is intentional.

@mvtglobally
Copy link

@neil-marcellini Based on the PR #8569 screenshots, there should be something about "Collaboration..." If the changes you are referring to were more recent, then maybe this is not an issue then.

@TomatoToaster
Copy link
Contributor

Ah those screenshots were with outdated data I think. But we do want to revert to the original welcome message like we're discussing here, so let's keep this issue to do that. @neil-marcellini you can make the PR for it if you're interested and I can review it. Or I can make it if you prefer.

@neil-marcellini
Copy link
Contributor

I would be happy to put up a PR to revert those changes. I'll put it up soon and request your review.

@trjExpensify
Copy link
Contributor

Thank you, @neil-marcellini!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Development

No branches or pull requests

5 participants