Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Search page - First user is highlighted once any value is entered/deleted in the field #9604

Closed
kbecciv opened this issue Jun 28, 2022 · 2 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR #7702

Action Performed:

  1. Login to https://staging.new.expensify.com/
  2. Open search page/new group/new chat/split bill
  3. Highlight any result via arrow buttons
  4. Start typing any text in the search fields and delete it

Expected Result:

Once text in search field is deleted – the focus should be where you left it and you should be able to use the arrows to navigate focus (as before). If highlighted item still present in search results - it's should be stay focused
The same for any page with user searching: new chat, new group, split bill, search page, workspace invitation

Actual Result:

First item is highlighted once any value is entered in Search field

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5628806_Screen_Recording_2022-06-28_at_21.11.46.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2022

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv changed the title Web - Search page - First item is highlighted once any value is entered/deleted in the field Web - Search page - First user is highlighted once any value is entered/deleted in the field Jun 28, 2022
@iwiznia
Copy link
Contributor

iwiznia commented Jun 28, 2022

I don't think this is an issue, saving the position of your selected item after the search has changed is not needed and I don't think it would even be expected. IMO the current behavior is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants