Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New group- Text for the maximum number (8) of participants is repeated twice #9606

Closed
kbecciv opened this issue Jun 28, 2022 · 5 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented Jun 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in any account
  2. Click on the green plus button
  3. Click on Create Group
  4. Start the group creation flow and add 8 participants.
  5. Verify you're showed a message that you reached the max participants.

Expected Result:

Text for the maximum number (8) of participants is repeated twice

Actual Result:

Text for the maximum number (8) of participants is displayed only once

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 28, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2022

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@chiragsalian
Copy link
Contributor

I think this got broken in this PR - #7702
More specifically here since there is already a header message im not sure why we're passing that prop. Investigating.

@chiragsalian
Copy link
Contributor

I see the same issue when splitting a bill too.
image

@chiragsalian
Copy link
Contributor

cc @roryabraham, i see you added the message on the bottom very recently. I couldn't find a GH issue where its specific to have it at the bottom. Do you know why you added it - here?

If not i was planning on updating this to remove the message from the bottom to keep it similar to whats on prod. Let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

4 participants