Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOU- Missing bullets after clicked on the currency symbol #9614

Closed
kbecciv opened this issue Jun 28, 2022 · 10 comments
Closed

IOU- Missing bullets after clicked on the currency symbol #9614

kbecciv opened this issue Jun 28, 2022 · 10 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 28, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to staging.new.expensify.com
  2. Log in with any account
  3. Press the big green + to open the global create menu.
  4. Select "request money"
  5. Tap on the currency symbol ($ in US)

Expected Result:

Bullets should be displayed after clicked on the currency symbol

Actual Result:

Missing bullets after clicked on the currency symbol

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.79.2

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.660.mp4

1

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 28, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 28, 2022

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

This may be a side-effect of #7702

@luacmartins
Copy link
Contributor

luacmartins commented Jun 29, 2022

@roryabraham is this the new expected UI for currency list?

@roryabraham
Copy link
Contributor

roryabraham commented Jun 29, 2022

Yes, this is the new expected UI. Do we need to update the regression tests? cc @isagoico

@sketchydroide
Copy link
Contributor

Yeah I was coming to ask why we need the bullets, it looks better without them.
Going to remove blocker

@sketchydroide sketchydroide removed the DeployBlockerCash This issue or pull request should block deployment label Jun 29, 2022
@roryabraham roryabraham added Weekly KSv2 and removed Hourly KSv2 labels Jun 29, 2022
@roryabraham
Copy link
Contributor

We can close this as soon as we confirm we've updated regression tests to reflect the new UI on this page.

@luacmartins
Copy link
Contributor

@kbecciv @mvtglobally do we need to update regression tests to reflect the new UI on this page?

@isagoico
Copy link

@luacmartins @roryabraham Steps in the regression don't mention the checkmark, we only need to verify that the currency is selected in the currency list. I think we're good to close this out without any changes there.

@luacmartins
Copy link
Contributor

Thanks for confirming @isagoico! Closing issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants