-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOU- Missing bullets after clicked on the currency symbol #9614
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @luacmartins ( |
This may be a side-effect of #7702 |
@roryabraham is this the new expected UI for currency list? |
Yes, this is the new expected UI. Do we need to update the regression tests? cc @isagoico |
Yeah I was coming to ask why we need the bullets, it looks better without them. |
We can close this as soon as we confirm we've updated regression tests to reflect the new UI on this page. |
@kbecciv @mvtglobally do we need to update regression tests to reflect the new UI on this page? |
@luacmartins @roryabraham Steps in the regression don't mention the checkmark, we only need to verify that the currency is selected in the currency list. I think we're good to close this out without any changes there. |
Thanks for confirming @isagoico! Closing issue! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Bullets should be displayed after clicked on the currency symbol
Actual Result:
Missing bullets after clicked on the currency symbol
Workaround:
Unknown
Platform:
Where is this issue occurring?
Version Number: 1.1.79.2
Reproducible in staging?: Yes
Reproducible in production?: No
Email or phone of affected tester (no customers): any
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.660.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: