Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkage workaround for macOS in test/clustertest/testplugin applies to Cygwin as well #641

Open
wyoung opened this issue May 16, 2019 · 0 comments

Comments

@wyoung
Copy link

wyoung commented May 16, 2019

I'm not exactly sure how you want to fix this. This works for me:

diff --git a/test/clustertest/testplugin/Makefile b/test/clustertest/testplugin>
index 0c02403..0662c43 100644
--- a/test/clustertest/testplugin/Makefile
+++ b/test/clustertest/testplugin/Makefile
@@ -51,9 +51,9 @@ ifneq ($(MAKECMDGOALS),clean)
 -include $(DEP)
 endif

-# OSX needs to re-link the libraries for some reason
+# Non-Linux linkers usually won't find the libraries implicitly
 UNAME_S := $(shell uname -s)
-ifeq ($(UNAME_S),Darwin)
+ifeq ($(UNAME_S),$(filter $(UNAME_S),Darwin CYGWIN_NT-10.0))
 LIBRARIES = -L../../../ -L../../../mbedtls/library -rdynamic -lpcrecpp -lbedro>
 endif

However, since I've never seen any system but Linux chase linkage implicitly, you might want to flip the sense of the test around, and just check for "not Linux." It'd be simpler, though it might be an over-reach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant