Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-resampling unnecesary files #1634

Open
1 task
jan-petr opened this issue Mar 5, 2024 · 0 comments
Open
1 task

Avoid re-resampling unnecesary files #1634

jan-petr opened this issue Mar 5, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@jan-petr
Copy link
Contributor

jan-petr commented Mar 5, 2024

Description

The step 8 Resample to standard space (line 430) is run also when FLAIR, rT1, rcT1 are missing in the standard space. Which doesn't make sense as these are always removed during cleaning. So this has to be rewritten while focusing on the PV_PGM files. We should merge #1543 and #1588 before continuing work on this.

HENK: Not sure what you mean by this. I had to search. So you mean xASL_module_Structural-> step 8.
Now I get what you mean. The answer is: we need these standard space copies for the visual QC JPGs created in step 10 Visual QC. E.g., we use FLAIR and rc1T1 to show the registration of FLAIR to T1w. We use rT1 to show the lesion filling.

We could improve this by creating the QC directly within the wrapper that creates it's output, but this is tricky for the structural module because of the interdependence between the FLAIR and T1w NIfTIs/images. Another thing we could do is to have an automatic way to transform images to standard space if they are requested but only exist in native space. This would be nice as a fail-safe, but less efficient perhaps then transforming multiple images in one go.

Tasks

  • Fix xyz in function xASL_[abc]_...

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

@jan-petr jan-petr added the bug Something isn't working label Mar 5, 2024
@jan-petr jan-petr added this to the Release 1.12.0 milestone Mar 5, 2024
@jan-petr jan-petr self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant