Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisiting visit/sessions/runs #775

Open
Tracked by #165
jan-petr opened this issue Aug 16, 2021 · 0 comments
Open
Tracked by #165

Revisiting visit/sessions/runs #775

jan-petr opened this issue Aug 16, 2021 · 0 comments
Assignees
Labels
feature New feature, enhancement or request

Comments

@jan-petr
Copy link
Contributor

jan-petr commented Aug 16, 2021

Description

Correctly use the sessions/runs in BIDS terminology.

  1. Rename visit/session tokens in sourceStructure.json to sessions/runs
    • And make sure this is backwards compatible.
    • And write this correctly in the documentation
  2. Correctly use sessions/runs in BIDS
    • using also the correct subdirectories
    • and make sure that this works for structural as well
    • all function names, variable, comments should correctly reflect BIDS terminology
  3. Adapt BIDS2Legacy accordingly
    • including file structure
    • including variable and function names
  4. Adapt ExploreASL code
    • use variable and function names session and runs correctly in the code and output and comments, while keeping the internal structure untouched.
  5. Avoid double sub and ses prefix. Adding sub- as prefix is fine as long as we check if this is not double (in case this prefix sub- was already in the DICOM folder). Same for ses-

Requirements

Optional: add feature requirements here

How to test

Optional: insert description about how to test the code changes here

Release notes

Required: summarize the changes for the release notes here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, enhancement or request
Projects
None yet
Development

No branches or pull requests

3 participants