Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLIGHT MODE telemetry parameter not present when using Ardupilot #879

Closed
estebanavv opened this issue Sep 6, 2021 · 6 comments
Closed
Labels
closing 🚪 Will close if no new information is reported enhancement 🪄 New feature or request

Comments

@estebanavv
Copy link

estebanavv commented Sep 6, 2021

On Ardupilot I get 22 attributes but FLIGHT MODE is missing. Would it be possible to include it?
Others have experienced this before.
https://discuss.ardupilot.org/t/passthrough-telemetry-over-crsf-crossfire/62668/667

@estebanavv estebanavv added the enhancement 🪄 New feature or request label Sep 6, 2021
@schugabe
Copy link
Contributor

schugabe commented Sep 6, 2021

I don't know why flight mode is missing because this telemetry type is already supported and it looks like ardupilot is using the same frame type as betaflight does.

We current don't send the special ardupilot frame type that is described in #650

@StonedDawg
Copy link
Member

@schugabe i think I can start the test with this for #880

@MingchenZhang
Copy link
Contributor

MingchenZhang commented Oct 3, 2021

I check the ardupilot code and the CSRF code sends 16 bytes. The elrs definition is only 10 bytes. Exls RX just drop that packet since the buffer for it is smaller than the flight mode data in. I tried changing it to 16 and it works.
create a pull request in #945

@schugabe
Copy link
Contributor

schugabe commented Oct 6, 2021

I check the ardupilot code and the CSRF code sends 16 bytes. The elrs definition is only 10 bytes. Exls RX just drop that packet since the buffer for it is smaller than the flight mode data in. I tried changing it to 16 and it works. create a pull request in #945

Thank you for the PR!

@estebanavv you could test this feature by flashing master or wait for the next release to get it.

@estebanavv
Copy link
Author

@schugabe Thank you! . Do I have to flash RX, TX or both with master ?

@CapnBry
Copy link
Member

CapnBry commented Nov 4, 2021

This should be resolved by the longer flight mode available in 2.0. I'm going to tag it as closing and close it after 2.0 release unless there is more activity.

@CapnBry CapnBry added the closing 🚪 Will close if no new information is reported label Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closing 🚪 Will close if no new information is reported enhancement 🪄 New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants