Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded English artifacts in the CP #2375

Closed
igreil opened this issue Sep 6, 2022 · 4 comments · Fixed by #2376
Closed

Hardcoded English artifacts in the CP #2375

igreil opened this issue Sep 6, 2022 · 4 comments · Fixed by #2376

Comments

@igreil
Copy link
Contributor

igreil commented Sep 6, 2022

In Performance.php, line 56, the word "of" is hardcoded instead of using lang('of'). This only becomes apparent when using a separate language pack.

Also, the words "Total Execution Time" seem to be hardcoded. I have not been able to find a corresponding language string to translate. I am running EE 7.1.12 on a local staging server.

@igreil
Copy link
Contributor Author

igreil commented Sep 6, 2022

Easy to fix, though: e858542

@intoeetive
Copy link
Contributor

@igreil thanks for reporting this! Do you want to open the pull request with a fix?

@igreil
Copy link
Contributor Author

igreil commented Sep 7, 2022

I did open a pull request (#2376), hope this went well. My Git skills still aren't anywhere near where I'd like them to be :-)

@intoeetive
Copy link
Contributor

Yes, all good, thank you!
(next time you might want to create new branch, just in case you'll want to make additional changes in your 7.dev, but that's not critical)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants