Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional HTML elements to stylesheet #2685

Closed
blairliikala opened this issue Jan 3, 2023 · 3 comments · Fixed by #2693
Closed

Add additional HTML elements to stylesheet #2685

blairliikala opened this issue Jan 3, 2023 · 3 comments · Fixed by #2693
Assignees
Labels
enhancement New feature or request

Comments

@blairliikala
Copy link

Add the additional types to the control panel stylesheet, such as <input type="search"> url date (and date's variations). Currently when adding these types they show unstyled. Only a few, such as text and textarea are shown correctly in the control panel. These additional types add better semantic value, and come with benefits for that type, but the lack of styling makes them less ideal to use.

Additionally style the read-only input property.

Add styling for the additional elements:

  • <dl>
  • <details> (and replace the show/hide field input, I have some styles for this one)
  • <progress> (and replace the less semantic div progress bar)
  • <menu>
  • <dialog> (and change the modals and alerts to use it)

Increasing the use of the different HTML elements increases semantic markup, and improves accessibility.

[x] I am capable and would like to work on implementation of this feature if it is considered.

@intoeetive
Copy link
Contributor

@blairliikala are you referring to the fact that if add-on is providing inputs for CP pages (such as custom fieldtypes), those don't have styles at all by default? (maybe a screenshot here would be useful)

@blairliikala
Copy link
Author

blairliikala commented Jan 3, 2023

Screenshot 2023-01-03 at 10 06 08 AM

The code for that is:

      $html = "<input type='text'><br />";
      $html .= "<input type='search'><br />";
      $html .= "<input type='date'>";

      return $html;

And yes on if an add-on is providing inputs, but also in the form service.

@blairliikala
Copy link
Author

blairliikala commented Jan 3, 2023

Screenshot 2023-01-03 at 10 09 35 AM

So within a ee:_shared/form array, if the type was url or search..etc. then it would be blank.

array(
   'title' => lang('test'),
   'desc' => lang('test_desc'),
   'fields' => array(
     'test_url' => array(
         'type' => 'url',
     )
   )
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants