-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configuration API #22
Comments
I don't have too much time to the end of the year. I'm going to do this job after you part because you can change or simplify something. |
Yeah no worries. I ended up with another week of free time, so I will see what I can get done. :) FWIW, I have the v2 performance down to 276us. So that's 200us of bloat currently that I hope to ween down today. |
276us sounds better :) |
Alright, I managed to get this down to 165us. (Initially I said 215us, but that was due to turning off one of the caches). It's a much more simplified model, but I have a lot of broken things now that I need to get fixed. The reason why it was so slow was:
Here are the reasons why it is 165us vs. 76us in v1:
So now we're sitting at about twice as slow as v1. Hey, twice the features, half the speed. 😆 I am not sure how much more I can squeeze out of it. I think this is a good point to stop at and if we really want to squeeze more performance out of it we can do it some other time. In any case, it might take me another day or so to get all the functionality back. Maybe a little bit more. I am hoping to incorporate the new configuration as discussed here and hopefully get it right. Then I can finally start working on that deserializer and call this thing done. :P |
Yes it is good result for this moment! |
It is inspired configuration from automaper. https://github.com/AutoMapper/AutoMapper. |
OK great... I have used AutoMapper and have found it a little too complicated for my tastes. :( Of course, I am also the same person that checked in an overly-complicated v2 serializer on my first try. 😆 But, I do like it's API. I like your API/pseudo-code above and will use that as a reference/inspiration. 👍 |
In this task I have to do profile. |
This should all now be done and available in v2. If you encounter a problem around expected functionality, please open a new issue (or issues :)) and we will take it from there. |
Pre-release deployment for this feature can be found at these feeds: |
ExtendedXmlSerializer should have a configuration API that allows users to setup the configuration of the serializer and then instantiate it accordingly. From #20 (comment):
for example:
The text was updated successfully, but these errors were encountered: