Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support nginx reload. #12

Closed
beacer opened this issue May 23, 2017 · 10 comments
Closed

support nginx reload. #12

beacer opened this issue May 23, 2017 · 10 comments
Labels

Comments

@beacer
Copy link

beacer commented May 23, 2017

Nginx reload function doesn't work.

Environment

  1. F-stack version: master:afba4e3b
  2. CPU: Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz
  3. OS: CentOS Linux release 7.2.1511 (Core)
  4. Kernel: 3.10.0-327.el7.x86_64

Steps

  1. setup f-stack and nginx app, make sure curl works
  2. change the nginx configure file /usr/local/nginx_fstack/conf/nginx.conf
    e.g., add new server (listen port), or add a proxy server(upstream)
  3. try reload with 'killall -SIGHUP nginx'

consider fstack-nginx is working in "single-process" mode, no master process. So use killall to send signal to all processes.

Expect that new configure applied, actually it does not. Even the curl fails after "reload".

Reproducible

Being able to reproduce.

@whl739
Copy link
Member

whl739 commented May 23, 2017

Nginx reload is not supported for now. Because we didn't implement/hook the fork function, all processes are working in NGX_PROCESS_SINGLE mode.
This will be fixed after we implement/hook fork.

@whl739 whl739 added the todo label May 24, 2017
@whl739 whl739 changed the title nginx reload failed. support nginx reload. May 24, 2017
@beacer
Copy link
Author

beacer commented Jun 13, 2017

@whl739 just wondering if fork be implemented on the next release (July) or not ? Thanks!

@whl739
Copy link
Member

whl739 commented Jun 13, 2017

fork will be implemented on the next release (July).

@friendwu
Copy link

friendwu commented Jun 15, 2017

@whl739 sorry, I don't quite understand, and would you please teach me, why should f-stack implement fork hook?

I'm now porting my project(DNS Authoritative Server) to f-stack, using the master-worker pattern, and... it seems to work well:

After master start running, it calls the "ff_mod_init" and then forks the worker, worker finally calls the "ff_init" and "ff_run", are there any problems which I haven't found?

@whl739
Copy link
Member

whl739 commented Jun 15, 2017

@friendwu
All I really want to do is what you say, i just want to wrap them in fork.Thus user's code can be changed as little as possible.

@haoyixin
Copy link

@whl739 how does this going?thx.

@whl739
Copy link
Member

whl739 commented Jul 22, 2017

Sorry, recently, i was busy with other works.
This may be delayed for few weeks.

@haoyixin
Copy link

@whl739 I attended a sharing of Intel yesterday, and Intel recommend f-stack for us, we want to try it on our lb on mesos cluster. So, really looking forward to this feature and thanks for your quick response.

@haoyixin
Copy link

@whl739 how does this going? ^ᗜ^

@whl739
Copy link
Member

whl739 commented Aug 14, 2017

Working now. May be done this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants