Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

当图片超出屏幕宽度后，解析后被强制赋值为屏幕宽度 #59

Open
shiiiiiiji opened this issue Dec 28, 2018 · 4 comments
Open

当图片超出屏幕宽度后，解析后被强制赋值为屏幕宽度 #59

shiiiiiiji opened this issue Dec 28, 2018 · 4 comments

Comments

@shiiiiiiji
Copy link

这里的处理是不是过于强硬了一点，一般在外层都会有容器包裹的，如果宽度是屏幕宽度，就会溢出
@F-loat
Copy link
Owner

F-loat commented Dec 28, 2018

有其他属性配合的，另外好过默认情况

@shiiiiiiji
Copy link
Author

shiiiiiiji commented Dec 29, 2018 •
edited
Loading

这种情况结合我们自己的业务，我修改成了宽度100%。

@F-loat 个人觉得这种方式会兼容性更好一点。不知道其他配合的相关属性是啥？

另外再提个小bug，styleStr可能为undefined，虽然无伤大雅。

修改部分源码参见pr #60

@shiiiiiiji shiiiiiiji mentioned this issue Dec 29, 2018
Open
@F-loat
Copy link
Owner

F-loat commented Dec 29, 2018

不太记得为什么这样处理了，原库不知道有这个处理没，另一个 pr 应该就是关于这个问题的

@shiiiiiiji
Copy link
Author

我看看

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiiiiiiji @F-loat