Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate signature_pad 4.0.2 not working in a webcomponent environment #236

Closed
F0rce opened this issue Jan 20, 2022 · 0 comments
Closed
Assignees
Labels
fixed in live Has been uploaded to the vaadin directory

Comments

@F0rce
Copy link
Owner

F0rce commented Jan 20, 2022

Describe the bug
While giving the frontend Webcomponent (lit-signature-pad) a bigger overhaul I tried to update the npm package (signature_pad) to 4.0.1

I changed to code to use the new EventEmitter methods that were mentioned in the changelog. But the "endStroke" Event (mousebutton was released to stop painting), which is used to send the image uri to the Java Backend was never emitted, where "beginStroke" (mousebutton is clicked and hold to start painting) was always send correctly.

Need to investigate a bit more, but still wanted to make a minor release.

To Reproduce
Steps to reproduce the behavior:

  1. Update signature_pad to 4.0.1
  2. Refactor code to use EventEmittor (.addEventListener)
  3. "endStroke" is never sent

Expected behavior
"endStroke" Event should be sent

Edit:
Signature_Pad 4.0.2 has been released, so I have to test it with the new version.

@F0rce F0rce added addition in later release Something has to be added in a later (bigger) release investigating Investigating this issue labels Jan 20, 2022
@F0rce F0rce self-assigned this Jan 20, 2022
@F0rce F0rce changed the title Investigate signature_pad 4.0.1 not working in a webcomponent environment Investigate signature_pad 4.0.2 not working in a webcomponent environment Jan 25, 2022
@F0rce F0rce closed this as completed in ab6d38d Apr 13, 2022
@F0rce F0rce added fixed in live Has been uploaded to the vaadin directory and removed addition in later release Something has to be added in a later (bigger) release investigating Investigating this issue labels Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed in live Has been uploaded to the vaadin directory
Projects
None yet
Development

No branches or pull requests

1 participant