Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restrictedSrcAddressApp required but missing in failover example yaml files #10

Closed
JeffGiroux opened this issue Jul 11, 2022 · 6 comments
Labels
bug Something isn't working

Comments

@JeffGiroux
Copy link

Describe the bug

The parameter 'restrictedSrcAddressApp' is set to be required 'yes' but it is not listed in the example yaml files. As a result, if user uses example failover yaml file, it is missing the parameter. The deployment will fail in google when python template tries to read the value.

Expected behavior

User should be able to pull down example yaml file that indicates all required and/or optional values. This way user is forced to enter values into yaml that are required and missing.

Current behavior

Parameter is required, but it is missing from example yaml. GCP deployment fails with an error that the parameter and value is basically missing.

Possible solution

Make sure that the restrictedSrcAddressApp parameter is in the example yaml files as required for all templates. For reference, this is found in the Quickstart yaml example files but not failover. I did not check other templates.

Add this to the 'sample_failover_existing_network.yaml' for example...

      # restrictedSrcAddressApp:*
      # 0.0.0.0/0**
      restrictedSrcAddressApp:

Steps to reproduce

  1. clone repo, update yaml file, update runtime init file
  2. launch bigip deployment
  3. fails with missing parameter

Screenshots

n/a

Context

n/a

Your Environment

n/a

@shyawnkarim shyawnkarim added bug Something isn't working labels Jul 13, 2022
@shyawnkarim shyawnkarim modified the milestone: backlog Jul 13, 2022
@shyawnkarim
Copy link

Thanks for reporting this. I've added it to our backlog and it is being tracked with internal ID, ESECLDTPLT-3137.

@shyawnkarim
Copy link

Closing.

This issue was resolved with Release 2.4.0.0.

@shyawnkarim shyawnkarim modified the milestones: backlog, 2.4.0.0 Aug 24, 2022
@JeffGiroux
Copy link
Author

This is not fixed. The yaml file in failover existing is still missing the required parameter.

https://github.com/F5Networks/f5-google-gdm-templates-v2/blob/main/examples/failover/sample_failover_existing_network.yaml

@shyawnkarim
Copy link

Thanks for letting me know. This was improperly marked done and is still open in our backlog.

1 similar comment
@shyawnkarim
Copy link

Thanks for letting me know. This was improperly marked done and is still open in our backlog.

@shyawnkarim shyawnkarim modified the milestones: Release 2.4.0.0, backlog Sep 2, 2022
@shyawnkarim
Copy link

Closing. This issue was resolved (for real this time) with Release 2.5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants