Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM Helm Deployment strategy should be recreate #130

Closed
braunsonm opened this issue Nov 8, 2022 · 3 comments
Closed

IPAM Helm Deployment strategy should be recreate #130

braunsonm opened this issue Nov 8, 2022 · 3 comments
Labels
bug Something isn't working JIRA Added to JIRA board

Comments

@braunsonm
Copy link

Description

In the helm chart for the IPAM controller, it uses the default rolling update strategy. This is a problem for two reasons:

  1. The PVC should only be accessed by one pod at a time because multiple editing the same DB will cause issues
  2. Not all PV types support multiple binds at the same time.

Steps To Reproduce

  1. Deploy IPAM with the helm chart using a storage class that only supports one bind at a time
  2. Upgrade the existing deployment
  3. Notice how the deployment will never complete because the new pod cannot startup as an existing one is holding the PVC

Expected Result

Upgrades should happen transparently.

Actual Result

You need to scale the deployment to 0, then back up to 1

@braunsonm braunsonm added the bug Something isn't working label Nov 8, 2022
@trinaths
Copy link
Collaborator

Created [CONTCNTR-3678] for internal tracking.

@vklohiya
Copy link
Contributor

vklohiya commented Jan 3, 2023

Closing the issue as already fixed.

@vklohiya vklohiya closed this as completed Jan 3, 2023
@braunsonm
Copy link
Author

@vklohiya why is this not the default? The current setting can cause corruption and the PVC type doesn't allow multiple read/write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working JIRA Added to JIRA board
Projects
None yet
Development

No branches or pull requests

3 participants