Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes in 'NotReady' state are not removed from their pool(s) when using ServiceType Loadbalancer #2978

Closed
marcriddle opened this issue Jul 17, 2023 · 5 comments

Comments

@marcriddle
Copy link

Setup Details

CIS Version : 2.13.1
Build: f5networks/k8s-bigip-ctlr:latest
BIGIP Version: BIG-IP 15.1.5.1 Build 0.0.14 Point Release 1
AS3 Version: 3.45.0
Agent Mode: AS3
Orchestration: K8S
Orchestration Version: v1.25.9
Pool Mode: Nodeport

Description

Nodes in 'NotReady' state are not removed from pool when using ServiceType Loadbalancer. If nodes are in this state when a service is created, they are not added to the pool that is created, but if they transition to this state they are not removed from the pool. Additionally, when new nodes are added to a cluster or 'NotReady' nodes transition to 'Ready' they are not added to the pool.

We have some automated processes that build, destroy, and reboot nodes, and part of this lifecycle involves the nodes transitioning to 'NotReady' before being restarted/destroyed. Ideally, they would be removed from any bigip pools at this point, as if not they'll need to fail health checks before being marked down, resulting in some number of failed requests to that node.

Steps To Reproduce

  1. Create service of type 'LoadBalancer'
  2. Stop kubelet on a node that belongs to the pool that was created, or otherwise transition node to 'NotReady'
  3. Observe that node is still a member of the pool

Expected Result

Nodes marked 'NotReady' should be removed from pools that they belong to.

Actual Result

Nodes remain in pool and are not removed

@marcriddle marcriddle added bug untriaged no JIRA created labels Jul 17, 2023
@trinaths
Copy link
Contributor

trinaths commented Jul 18, 2023

@marcriddle Please mail automation_toolchain_pm@f5.com this issue with required CIS configuration and resource examples to reproduce at our end.

@trinaths trinaths added awaiting response Awaiting response and removed untriaged no JIRA created labels Jul 18, 2023
@marcriddle
Copy link
Author

Sent an email to the above address with details, please let me know if any additional information is needed.

@trinaths
Copy link
Contributor

Created [CONTCNTR-4083] for internal PD tracking. ETA ~ 2.14

@trinaths trinaths added JIRA and removed awaiting response Awaiting response labels Jul 26, 2023
@vklohiya
Copy link
Contributor

vklohiya commented Aug 21, 2023

Fixed with #2855. Fix will be available in CIS 2.14.0 release.

@vklohiya
Copy link
Contributor

Already fixed. Hence closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants