bigip_ssl_certificate and bigip_ssl_key import not supported properly

[rossbeehler]

Environment

• Bigip Version: 12x
• Terraform Version: 0.14.6
• Terraform bigip provider Version: 1.6.0

Summary

The bigip_ssl_certificate and bigip_ssl_key resources attempt to support importing, but do not properly include partition in the name/id of the resource, but demands it in the data of the request, which doesn't make sense for import commands, nor follows conventions of other resources.

Steps To Reproduce

terraform import bigip_ssl_certificate.c1 "/Common/c1.crt"

bigip_ssl_certificate.c1: Importing from ID "/Common/c1.crt"...
bigip_ssl_certificate.c1: Import prepared!
  Prepared bigip_ssl_certificate for import
bigip_ssl_certificate.c1: Refreshing state... [id=/Common/c1.crt]

Error: Cannot import non-existent remote object

While attempting to import an existing object to
bigip_ssl_certificate.c1, the provider detected that no object
exists with the given id. Only pre-existing objects can be imported; check
that the id is correct and that it is associated with the provider's
configured region or endpoint, or use "terraform apply" to create a new remote
object for this resource.

Expected Behavior

Should import the resource

Actual Behavior

Errors as shown above

Note that the issue is in func resourceBigipSslCertificateExists of /bigip/resource_bigip_ssl_certificate.go (and corresponding func/file for bigip_ssl_key). It demands a partition field in the resource data and always combines it with the id instead of assuming the id has partition already baked in, which is the normal convention for bigip resources. Of course, changing that would present a problem since partition is actually a resource field, so fixing this simply for import may break plan/apply.

[nmenant]

Thanks for the feedback, tracking this internally with INFRAANO-219

[RavinderReddyF5]

@rossbeehler Issue fixed in v1.8.0, can you please verify it with v1.8.0