New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two different deserializations of Faction #1041

Closed

Brutus5000 opened this issue Nov 18, 2018 · 1 comment

Member

Brutus5000 commented Nov 18, 2018

We have Jackson annotations telling me that the ordinal is supposed to be used: https://github.com/FAForever/downlords-faf-client/blob/develop/src/main/java/com/faforever/client/game/Faction.java#L33

But the client is using Gson, so the Jackson annotations have no effect. So actually FactionTypeAdapter should be used: the https://github.com/FAForever/downlords-faf-client/blob/develop/src/main/java/com/faforever/client/remote/gson/FactionTypeAdapter.java

But which one is correct now? I need this information as the Java server is supposed to send the faction to the client in preparation of GW.

Member

Sheikah45 commented Jun 4, 2021

Conflict deserialization no longer present in client repo

Sheikah45 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment