Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop at FafServerAccessorImpl.java:431: seems to be a noop #1079

Closed
Wesmania opened this issue Dec 28, 2018 · 1 comment
Closed

Loop at FafServerAccessorImpl.java:431: seems to be a noop #1079

Wesmania opened this issue Dec 28, 2018 · 1 comment

Comments

@Wesmania
Copy link
Collaborator

There's a piece of code at FafServerAccessorImpl that goes like this:

for (Class<?> type : ClassUtils.getAllInterfacesForClassAsSet(messageClass)) {
    messageListeners.getOrDefault(messageClass, Collections.emptyList())
    .forEach(consumer -> consumer.accept(serverMessage));
}

The preceding loop sets messageClass to Object, so it seems to be a no-op.

@Sheikah45
Copy link
Member

No longer an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants