Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map Vault: Search for width/height in km rather than pixels #1105

Closed
Justify87 opened this issue Feb 6, 2019 · 5 comments
Closed

Map Vault: Search for width/height in km rather than pixels #1105

Justify87 opened this issue Feb 6, 2019 · 5 comments
Milestone

Comments

@Justify87
Copy link

grafik

The first parameter (max players) doesn't matter here. No matter if I use only height or only width or both, no maps are found.

This query gives all maps greater than 20k:
latestVersion.width=gt="2000"
This though does not work:
latestVersion.width=="2000"
This shows setons and dual gap (20k maps):
latestVersion.width=lt="2000";latestVersion.maxPlayers=="12"

Maybe width and height are accidentally converted to strings and searched/sorted alphanumerically? idk

As a side note:
Plz use symbols instead of words here:
grafik

Much faster to understand because of icon recognition and they don't need translation

@Brutus5000
Copy link
Member

I can't see the German translation on this screenshot but in English, the name clearly indicates that width and height are in pixels and not in kilometers.
256px = 5km
512px = 10km
...

Could take an improvement, but technically no error.

@Justify87
Copy link
Author

There is no mentioning of the unit being pixels in the translation. Why would you even do that if the game measures it in kilometers and all users talk about map sizes in kilometers, except maybe map creators? What ever the reasons - at least both should be available. Otherwise it's just confusing and to the average user it surely appears to be an error. Since some forum post mentioned this client will be the standard client from march 2019 onwards this is definitley something that should be working as expected for the average user.

@Brutus5000 Brutus5000 changed the title Map Vault: Query for maps size (height, widht) dooes not work Map Vault: Search for width/height in km rather than pixels Feb 8, 2019
@Brutus5000
Copy link
Member

I know. That's not the only case where the query builder is not optimal.
For the pixels: this is what is read from the map files and stored in the database. Technically we can, of course, map this to kilometers but I do not believe that the current query builder architecture is capable to do this.
Needs an overall refactoring to make it more user-friendly. This is also a known topic in the feedback thread.

@germanicianus
Copy link
Contributor

There is no mentioning of the unit being pixels in the translation.

Yes, at least not in the German translation. In English and Chinese the unit "px" is mentioned.

@Sheikah45
Copy link
Member

Fixed in #2044

@Sheikah45 Sheikah45 added this to the v1.3.0 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants