Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish theming implementation #1158

Closed
Brutus5000 opened this issue Apr 21, 2019 · 2 comments
Closed

Finish theming implementation #1158

Brutus5000 opened this issue Apr 21, 2019 · 2 comments

Comments

@Brutus5000
Copy link
Member

  1. There is no documentation about how to create a theme, what files are required (e.g. theme.properties) and where to put it. There is also no documentation of the versioning concept.
  2. The combo box for choosing a theme in the settings is disabled in the fxml. You cannot choose a valid theme if you have one.
  3. (After manually enabling the combobox) If you choose a theme that has disabled the combobox you are locked in it forever (or until you delete the preferences). [That happened to me with a copy of the current theme and I was locked out again]. This setting should be set in the code to prevent shenanigans of theme creators.
  4. The current theme does not seem to be remembered in th combobox after restart.
@micheljung
Copy link
Member

Theming was never finished, but it's documented in code :D The button is, therefore, disabled on purpose.

@micheljung micheljung changed the title Theme system is broken Finish theming implementation Apr 24, 2019
@Brutus5000
Copy link
Member Author

see #1792

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants