Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user folder/encoding issue #1201

Closed
PhilipJFryFAF opened this issue May 6, 2019 · 6 comments
Closed

user folder/encoding issue #1201

PhilipJFryFAF opened this issue May 6, 2019 · 6 comments

Comments

@PhilipJFryFAF
Copy link
Collaborator

PhilipJFryFAF commented May 6, 2019

The game Supreme Commander - Forged Alliance looks up this directory to find maps/mods (outside of the ones in the game install directory):
C:\Users\%username%\Documents\My Games\Gas Powered Games\Supreme Commander Forged Alliance\mods
C:\Users\%username%\Documents\My Games\Gas Powered Games\Supreme Commander Forged Alliance\maps
The Client stores mods/maps from the vault in those 2 directories respectively.

If a user has uncommon chars in the windows username (e.g. Фёдор) then the game will not be able to pick up maps/mods from that folder which results in people being unable to play with such mods/maps

The legacy client deals with this by storing maps/mods in
C:\ProgramData\FAForever\user\My Games\Gas Powered Games\Supreme Commander Forged Alliance\maps\ and
C:\ProgramData\FAForever\user\My Games\Gas Powered Games\Supreme Commander Forged Alliance\mods\

I suggest we do the same unless someone has a better idea.

Possible alternatives include:

  1. storing maps/mods in the game install directory
  • is a known location (since the user has to tell the client where fa is installed anyway)
  • allowing the user to store these files on a drive that is not the one containing the OS
  • mods/maps in the game install are not being printed in the game log which makes bug tracking/troubleshooting a lot harder
  1. allowing the user to select a mod/map directory of their own choice
  • maximum freedom
  • probably too much freedom for the average user

attached a client and game log where the windows username was Фёдор and i stored maps/mods in the user directory with downlords faf client
the client was able to see the map/mod but the game itself couldn't use them despite looking up the user folder for them
downlords-faf-client.log
game.log

@1-alex98
Copy link
Member

1-alex98 commented May 6, 2019

What about a setting with

  • user specific maps/mods location
  • faf specific maps/mods location

and the user can toggle between the two. and we make the programdata one the default so nobody has any issues

@PhilipJFryFAF
Copy link
Collaborator Author

i forgot to add one more drawback to the freely selected folder:
since you have to tell the game via the init file where to look for mods/maps the user specific folder would not be recognized by the non-faf patched game (same as the programdata fallback) and if someone wipes their client prefs (cause of whatever issue they have with their client settings) then the user will have to set that path again in the client

@1-alex98
Copy link
Member

1-alex98 commented May 6, 2019

Well but the toggle option seems good like that nothing can go wrong. Both dirs are ok

@1-alex98
Copy link
Member

1-alex98 commented May 6, 2019

@zlo-faf
Copy link

zlo-faf commented May 27, 2019

To me, storing maps and mod in game folder looks like the best idea. Mainly because people, for some reason tend to creat small C drive partition, and fill it with ragbage and then having trouble with free space.

@1-alex98
Copy link
Member

No that is not possible... game is only gonna be able to find maps/ mods in certain folders...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants