Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re factor the way notifications are called #1309

Closed
1-alex98 opened this issue Jun 23, 2019 · 1 comment
Closed

Re factor the way notifications are called #1309

1-alex98 opened this issue Jun 23, 2019 · 1 comment

Comments

@1-alex98
Copy link
Member

Make all the logic in the Notification service and define what notifications there are via an enum(at least the standard ones), also call the audioService from there.
@Sheikah45 Sheikah45 mentioned this issue Jan 14, 2021
Closed
@Sheikah45
Copy link
Member

Enum not viable really due to how different notifications are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/#1309 notification service FAForever/downlords-faf-client
2 participants
@1-alex98 @Sheikah45