Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exe download #1344

Closed
PhilipJFryFAF opened this issue Jul 6, 2019 · 6 comments
Closed

exe download #1344

PhilipJFryFAF opened this issue Jul 6, 2019 · 6 comments
Labels

Comments

@PhilipJFryFAF
Copy link
Collaborator

every time a user hosts or joins a game on faf he will download the ForgedAlliance.exe file

i assume the client checks the MD5 value and compares it with the one on the server and since the exe gets modified on the client side after downloading the MD5 doesn't add up which causes the problem

would be nice if users would not have to download the 12MB of exe each time the host/join any lobby

@norraxx
Copy link
Collaborator

norraxx commented Jul 16, 2019

IMHO, this should be solved on HTTP via HEAD request.
Ask server for Last-Modified, if date is modified, then download.
Nginx as it is, doesn't compute md5 and create md5 response on server side is not efficient. Even with cache server will compute md5 for all files that users will download. It's hard hit on HDD.

@norraxx norraxx added the bug label Jul 16, 2019
@1-alex98
Copy link
Member

What? @norraxx no it is saved in the database XD

@1-alex98
Copy link
Member

To be honest it works all the time it is just this time @Geosearchef did the patch and he did not know about the client sided modification i think and did not enter the correct md5 value into the db(it worked before).
Tho the client sided modification is strange and i dont know what it is good for and we might probably wanna try to get rid of it...

@norraxx
Copy link
Collaborator

norraxx commented Jul 16, 2019

Horrible decision to store data in db :-/

@1-alex98
Copy link
Member

It is not really an issue...

@PhilipJFryFAF
Copy link
Collaborator Author

so apparently not a client issue - afaik brutus wants to change the way the exe is being deployed which would also solve this issue (i suppose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants