Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new "Reset Settings" function does nothing #1356

Closed
tatsujb opened this issue Jul 21, 2019 · 5 comments
Closed

new "Reset Settings" function does nothing #1356

tatsujb opened this issue Jul 21, 2019 · 5 comments
Labels

Comments

@tatsujb
Copy link
Contributor

tatsujb commented Jul 21, 2019

Screenshot from 2019-07-21 12-13-27

this function fails to do what it's text implies it would do.

clients.pref files being missing will erroneously trigger this window instead of just writing new clients.pref

pressing the "Yes" button in this prompt in a case where clients.pref is missing will result in nothing happening and FAF client being permanently unable to init until the .faforever folder is deleted entirely correctly triggering a total recreation of this folder including client.prefs

@tatsujb tatsujb changed the title new "Clear Settings" function does nothing new "Reset Settings" function does nothing Jul 21, 2019
@1-alex98
Copy link
Member

First:
Asking the user is needed some might wanna backup their settings...
Second:
The button is gonna delete the client.prefs file that is intended like that. The functionality would be too much some ppl would need to redownload coop etc.

Could u send me the log of this happening? I mean u said the client.prefs are missing anyway... So the prompt is simply wrong... I would assume it is some permission error that the client can not read or write the none existing client.prefs file and instead of showing that error it shows this prompt

@tatsujb
Copy link
Contributor Author

tatsujb commented Jul 22, 2019

yeah I'll get you a log when I get home tonight.

it's not supposed to currently be possible for the client to be stuck in an infinite init loop like it is if client.prefs is the only file missing, right?

I mean I don't think this is intended behavior.

@1-alex98
Copy link
Member

Well if it is missing it is created

@1-alex98
Copy link
Member

And when I should guess what happens in your case is that the client is unable to create it

@1-alex98 1-alex98 added the bug label Jul 22, 2019
@Sheikah45
Copy link
Member

Most likely user permissions error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants