Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconnecting does not refetch coop mission list #1516

Closed
Katharsas opened this issue Nov 28, 2019 · 3 comments · Fixed by #2536
Closed

Reconnecting does not refetch coop mission list #1516

Katharsas opened this issue Nov 28, 2019 · 3 comments · Fixed by #2536
Labels
bug S4 minor severity 4 - minor - minor loss of function, or other problem where easy workaround is present

Comments

@Katharsas
Copy link
Collaborator

Katharsas commented Nov 28, 2019 •
edited

Take API down, log in, start API, coop mission list will stay empty even if you click reconnect.
@Katharsas Katharsas added bug S4 minor severity 4 - minor - minor loss of function, or other problem where easy workaround is present labels Nov 28, 2019
@Askaholic
Copy link
Collaborator

This is because coop missions are loaded once when the controller is initialized:

downlords-faf-client/src/main/java/com/faforever/client/coop/CoopController.java

Line 150 in c39aed5

coopService.getMissions().thenAccept(coopMaps -> {

@1-alex98
Copy link
Member

load on display maybe

@Brutus5000
Copy link
Member

No. Load on display is not a good idea.
The reason why this happens is the caching: https://github.com/FAForever/downlords-faf-client/blob/develop/src/main/java/com/faforever/client/api/FafApiAccessorImpl.java#L487

We should evict all caches on logout.

@Sheikah45 Sheikah45 mentioned this issue Jan 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug S4 minor severity 4 - minor - minor loss of function, or other problem where easy workaround is present
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clear caches on logout FAForever/downlords-faf-client
4 participants
@Katharsas @Brutus5000 @Askaholic @1-alex98