Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameInfoMessage: gameType does not exist #1583

Closed
Brutus5000 opened this issue Feb 16, 2020 · 1 comment
Closed

GameInfoMessage: gameType does not exist #1583

Brutus5000 opened this issue Feb 16, 2020 · 1 comment
Labels
beginner-friendly bug

Comments

@Brutus5000
Copy link
Member

Describe the bug
The variable gameType in the class GameInfoMessage is unused and does not seem to be part of the server protocol. Thus it should be removed.

https://github.com/FAForever/downlords-faf-client/blob/develop/src/main/java/com/faforever/client/remote/domain/GameInfoMessage.java#L28
@Brutus5000 Brutus5000 added the bug label Feb 16, 2020
@Sheikah45
Copy link
Member

Fixed in 182fedd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner-friendly bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Brutus5000 @Askaholic @Sheikah45