Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replays in the vault fail to load more often than not #1608

Closed
ShittyReplayVault opened this issue Mar 5, 2020 · 5 comments
Closed

Replays in the vault fail to load more often than not #1608

ShittyReplayVault opened this issue Mar 5, 2020 · 5 comments
Labels

Comments

@ShittyReplayVault
Copy link

Starting replays (particularly larger team games) from the vault will very often start the game but then give an error and just leave FA on the menu.
The errors given look like this:

java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: 'init_fafbeta.lua' could be found.
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture$UniAccept.tryFire(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.postComplete(Unknown Source)
at java.base/java.util.concurrent.CompletableFuture.completeExceptionally(Unknown Source)
at com.faforever.client.task.CompletableTask.lambda$new$1(CompletableTask.java:17)
at javafx.base/com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEventImpl(Unknown Source)
at javafx.base/com.sun.javafx.event.EventUtil.fireEvent(Unknown Source)
at javafx.base/javafx.event.Event.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.EventHelper.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.Task.fireEvent(Unknown Source)
at javafx.graphics/javafx.concurrent.Task.setState(Unknown Source)
at javafx.graphics/javafx.concurrent.Task$TaskCallable.lambda$call$2(Unknown Source)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$9(Unknown Source)
at java.base/java.security.AccessController.doPrivileged(Native Method)
at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(Unknown Source)
at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at javafx.graphics/com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at javafx.graphics/com.sun.glass.ui.win.WinApplication.lambda$runLoop$3(Unknown Source)
at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.IllegalArgumentException: 'init_fafbeta.lua' could be found.
at org.springframework.util.Assert.isTrue(Assert.java:118)
at com.faforever.client.patch.SimpleHttpFeaturedModUpdaterTask.call(SimpleHttpFeaturedModUpdaterTask.java:83)
at com.faforever.client.patch.SimpleHttpFeaturedModUpdaterTask.call(SimpleHttpFeaturedModUpdaterTask.java:26)
at javafx.graphics/javafx.concurrent.Task$TaskCallable.call(Unknown Source)
at java.base/java.util.concurrent.FutureTask.run(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
... 1 more

To Reproduce
Start a replay from the vault such as this one: "https://content.faforever.com/faf/vault/replay_vault/replay.php?id=11183892"

@Brutus5000
Copy link
Member

The vault has become sentient. This is how it all starts! 😱

@1-alex98
Copy link
Member

1-alex98 commented Mar 5, 2020

grafik
Can u give an example of a game with regular faf as well or does it only aplly to faf beta?

@1-alex98
Copy link
Member

1-alex98 commented Mar 5, 2020

And I get the same error for your replay

@1-alex98
Copy link
Member

1-alex98 commented Mar 5, 2020

The replay u sent has malformatted info in it as it seems the replay file says it is a faf game the server says it is a faf beta game, I cosider that replay file as broken

@Sheikah45
Copy link
Member

This seems to be based on bad replay data. Also #1866 should fix issues although may still desync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants