Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace dancing ACU with sane gif #1665

Closed
BlackYps opened this issue Apr 2, 2020 · 16 comments
Closed

replace dancing ACU with sane gif #1665

BlackYps opened this issue Apr 2, 2020 · 16 comments

Comments

@BlackYps
Copy link
Collaborator

BlackYps commented Apr 2, 2020

For the love of god please replace the dancing ACU with a normal loading gif.
I even made one for you that you can use:

loading-circle

(it is a white circle on transparent background so it is suited for the dark client but looks not so good in a preview on white background)

@dmalukov
Copy link

dmalukov commented Apr 3, 2020

Debatable - I like dancing ACU.

@iczero
Copy link
Member

iczero commented Apr 3, 2020

I also like the dancing ACU

@1-alex98
Copy link
Member

1-alex98 commented Apr 6, 2020

Yes a setting to choose is probably needed

@micheljung
Copy link
Member

The dancing ACU consumes 20MiB of memory

@1-alex98
Copy link
Member

1-alex98 commented Jul 8, 2020

Yeah that might be fixed by making a gif with less quality

@BlackYps
Copy link
Collaborator Author

BlackYps commented Jul 8, 2020

or we use the spinning circle gif and all people that want the dancing acu can use a theme. Theme support is right around the corner, so we don't even need to code a setting to choose the gif anymore.

@Katharsas
Copy link
Collaborator

Katharsas commented Jul 8, 2020

Check if we can use a sane format like APNG instead of gif.
Gif is a horrible format and only has 1 bit transparency "channel" so you cannot create transparent gif that works on bright and dark background without artefacts, as seen in the gif above, which would become a theming problem.

@micheljung
Copy link
Member

APNG isn't supported by JavaFX https://bugs.openjdk.java.net/browse/JDK-8092356

@Katharsas
Copy link
Collaborator

Has animating an SVG path via PathTransition been tried? That should cost basically no memory and should work with UI scaling without any artefacts.

@JaggedAppliance
Copy link

Bump. I wanna know how many of the people that like this actually play ladder regularly.

@1-alex98
Copy link
Member

1-alex98 commented Sep 7, 2020

There is an article that explains how to make a theme. A theme for replacing the gif is mostly a matter of putting the gif in the correct folder...

@1-alex98
Copy link
Member

1-alex98 commented Sep 7, 2020

@JaggedAppliance
Copy link

The ACU should be in a theme, not the other way around.

@Farmsletje
Copy link

Something like this can indeed be nice for a theme but should by no way be the default. It's way too cringe for that

@BlackYps
Copy link
Collaborator Author

The new tmm UI will not have that gif

@Sheikah45
Copy link
Member

TMM killed the ACU

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants