Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an indication that a map is unranked in the custom games overview #1671

Closed
FemtoZetta opened this issue Apr 8, 2020 · 5 comments
Closed
Labels

Comments

@FemtoZetta
Copy link
Contributor

Should probably add an option to filter out unranked games, too.
Since recently some popular maps have been made unranked, this is more relevant than ever. In general players don't get proper feedback about whether a game is ranked or not before joining (some mods don't unrank for example).

@Sheikah45
Copy link
Member

The server doesnt send any information about whether a game is ranked or not afaik.

@dev-nulled
Copy link

@Sheikah45 is there logic somewhere that lists what mods count for ranked? I was already looking at a thumbnail overlay tweak to show if friends were in a game.

@Sheikah45
Copy link
Member

There is no logic in the client about which mods are ranked. The only way to get this info would be to query the api for every mod and map which can end up being a lot of api queries and we don't want to do that on every game update.

@dev-nulled
Copy link

Can't imagine it changes that often. Thoughts on caching the ruleset on client launch? (and possibly adding a new endpoint on the server side?)

@Sheikah45
Copy link
Member

This could really only be done by querying the api on every single new game creation which would cause quite the server load and there are too many maps to reasonably pull them all down and store the list locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants