Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitch integration #1741

Closed
tobias-strenger opened this issue Jun 1, 2020 · 11 comments
Closed

Twitch integration #1741

tobias-strenger opened this issue Jun 1, 2020 · 11 comments

Comments

@tobias-strenger
Copy link

(suggestion) Next to the username, indicate whether a livestream is available for this player. Add the option "watch live stream" to the context menu in addition to the "watch game" option.

@1-alex98
Copy link
Member

1-alex98 commented Jun 2, 2020

How to we know if ppl have a twitch stream?

@tobias-strenger
Copy link
Author

tobias-strenger commented Jun 3, 2020

ppl have to link their account
https://dev.twitch.tv/docs/authentication
you can get the live status using the stream endpoint https://dev.twitch.tv/docs/api/reference#get-streams

@1-alex98
Copy link
Member

1-alex98 commented Jun 3, 2020

Well such a links needs to be built u say...?

@1-alex98
Copy link
Member

1-alex98 commented Jun 3, 2020

Then that's the wrong project to open an issue

@tobias-strenger
Copy link
Author

tobias-strenger commented Jun 3, 2020

im not sure if i get what you mean by building a link in this case. obviously ppl have to confirm somewhere that the same person is behind twitch and faf acc. however, if you know which account you can simply check the status via api call. it returns an empty object in case the player is not streaming

@1-alex98
Copy link
Member

1-alex98 commented Jun 3, 2020

That would need website/api/db changes... Think that is a little overkill but that would be needed for such a simple feature I am afraid. First it needs integration there.

@1-alex98 1-alex98 closed this as completed Jun 3, 2020
@bukajsytlos
Copy link
Member

and then integrate in client, right? so why closed?

@bukajsytlos bukajsytlos reopened this Jun 3, 2020
@KionX
Copy link

KionX commented Jun 3, 2020

axel1200 likes to look for a reason to close.

@1-alex98
Copy link
Member

1-alex98 commented Jun 3, 2020

yes I do

@1-alex98
Copy link
Member

1-alex98 commented Jun 3, 2020

Because issues become useless once they reach a certain count. And if stuff is not really worth the effort then I normally close them :D

@Sheikah45
Copy link
Member

From my perspective on top of the integration into the db and api this would also require constantly checking twitch to see if people were streaming which is a bit much for the chat user list and not likely to happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants