Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement TMM queuing #1744

Closed
3 tasks done
Geosearchef opened this issue Jun 2, 2020 · 7 comments
Closed
3 tasks done

Implement TMM queuing #1744

Geosearchef opened this issue Jun 2, 2020 · 7 comments
Assignees

Comments

@Geosearchef
Copy link
Member

Geosearchef commented Jun 2, 2020

  • Display matchmaking queues
  • Join / leave / interfact matchmaking queues (and the server)
  • Game launch
@Geosearchef Geosearchef added this to In progress in Team Matchmaker Jun 2, 2020
@Geosearchef Geosearchef self-assigned this Jun 2, 2020
@Geosearchef Geosearchef moved this from In progress to Assigned in Team Matchmaker Jun 2, 2020
@Askaholic
Copy link
Collaborator

Askaholic commented Jun 3, 2020

Since each queue has a team_size associated with it, the client UI should prevent you from queueing into a queue for which your party is too large. Unavailable queues should be clearly identifiable in the UI.

We also need to make sure that whenever the party size changes (player joins or leaves), any ongoing queues are cancelled.

@Askaholic
Copy link
Collaborator

Askaholic commented Jun 4, 2020

Queue names should be localized. We should not be directly displaying the names sent by the server (unless localization string is not found), those are more internal identifiers.

We should make sure that everything works at smaller screen sizes too. For instance the "Available Queues" panel should be able to move below the party panel if the screen size is too small.

We should probably remove the profile images to save space.

@Geosearchef
Copy link
Member Author

The UI is built to work on smaller devices as well.

About the queuenames, we can't localize them as ww might dynamically add queues on the server (e. g. an event queue).

@Askaholic
Copy link
Collaborator

I tested it yesterday. Making the window small did not play nicely with the UI. The party panel would shrink to a minimum size and then push the queues panel off the screen. The queues panel should be able to pop below the party panel when needed.

While it's possible to add a special event queue, this doesn't me we shouldn't localize them. Yea the localization might lag behind the queue creation, but it's not like the queues are completely changing every day. We won't be getting rid of ladder any time soon. Use the technical name only as a fallback.

@Geosearchef
Copy link
Member Author

About the resize, the window is built to work at 1366x768, I'm not gonna make it work for anything lower.

"it should be able to pop bellw the party panel". This is really hard to implement. I thought about placing it there always, but that's bad for wide resolutions. It would also require a completely different layout for the queue cards, as blocks instead of rows.

@Askaholic
Copy link
Collaborator

Really? How is it done in the ladder tab? Because it works fine there.

@Katharsas
Copy link
Collaborator

People with laptops that have Full HD at 150% zoom in Windows (like me^^) end up with a window sized like on a 1280 * 720 screen (but of course sharper), so that would be the best minimum resolution/size target for some people.

@Askaholic Askaholic moved this from Assigned to In progress in Team Matchmaker Jun 28, 2020
@Geosearchef Geosearchef moved this from In progress to Done in Team Matchmaker Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants