Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can join ladder games through player context menu #1761

Closed
Askaholic opened this issue Jun 8, 2020 · 2 comments · Fixed by #1769
Closed

Can join ladder games through player context menu #1761

Askaholic opened this issue Jun 8, 2020 · 2 comments · Fixed by #1769
Assignees
Milestone

Comments

@Askaholic
Copy link
Collaborator

Describe the bug
When a player is starting a ladder game and they are the host, they will show up in the chat tab as “hosting” and players (who should not be in the game) can join their game through the context menu causing a bugged ladder game (joining player shows up as nomads faction and is set to observer)

To Reproduce
(Easier on test)

  1. Queue ladder with 2 players
  2. Close client for the guest before the game starts.
  3. Join the game with a third client through the context menu.

Expected behavior
Show ladder game hosts as “playing ladder” and don’t distinguish between hosts and guests.

OS
Linux or Windows

Wanna have the bug fixed quickly?
Visit Issue hunt...
Issue hunt

@1-alex98
Copy link
Member

1-alex98 commented Jun 8, 2020

But this should also be fixed on server, as this might allow uninvolved players to crash games on purpose even if we remove the option in the client.

@Askaholic
Copy link
Collaborator Author

Already done: FAForever/server#590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants