Client sends civilian as matchmaker faction

[Askaholic]

Some people trying to reproduce the rating bug on the test server and this happened:

TRACE    Aug 05  23:11:18 LobbyConnection                << Blodir: {'faction': 'civilian', 'mod': 'ladder1v1', 'state': 'start', 'command': 'game_matchmaking'}
ERROR    Aug 05  23:11:18 LobbyConnection                'civilian'
Traceback (most recent call last):
  File "/code/server/lobbyconnection.py", line 162, in on_message_received
    await handler(message)
  File "/code/server/lobbyconnection.py", line 849, in command_game_matchmaking
    self.player.faction = message['faction']
  File "/code/server/players.py", line 84, in faction
    self._faction = Faction.from_string(value)
  File "/code/server/factions.py", line 14, in from_string
    return Faction.__members__[value]
KeyError: 'civilian'
WARNING  Aug 05  23:11:18 LobbyConnection                Client Blodir dropped. Garbage command: {'faction': 'civilian', 'mod': 'ladder1v1', 'state': 'start', 'command': 'game_matchmaking'}

Somehow the client sent the string civilian, but it should only be sending one of uef, seraphim, cybran, aeon.

Wanna have the bug fixed quickly?
Visit Issue hunt...

[1-alex98]

That might be @FemtoZetta messing with the faction enum

[FemtoZetta]

I doubt that, this was all I changed in the enum:

[1-alex98]

ok cool, we will have to look into to it then

[Sheikah45]

Likely fixed with change to consistent java commons enum and matchmaker changes