Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update map when hosting a game #1986

Closed
mnooblet opened this issue Oct 15, 2020 · 12 comments · Fixed by #2114
Closed

Automatically update map when hosting a game #1986

mnooblet opened this issue Oct 15, 2020 · 12 comments · Fixed by #2114

Comments

@mnooblet
Copy link

I've a few maps which got a few plays, one actually got over 3k plays now and I updated the map and added textures and stuff but people still keep playing the old version...

It would be a nice feature to have to either

+force hosts to download the latest version of the map (?)
+or at least display a notice that there is a newer version and that the host can download the map before he creates the lobby

@1-alex98
Copy link
Member

I think that's a good idea

@chrsin
Copy link
Contributor

chrsin commented Oct 19, 2020

Very useful feature indeed!
As I see it we have some clarifications we need out of the way before this can be implemented though.

  1. How do we know a newly uploaded map is a new version of another map? (Does the author specify this? Maybe replace the existing version)
  2. Do we force the new version on the host? (Or does she select a map and then have a choice of version?)

@1-alex98
Copy link
Member

  1. We should force new versions

@1-alex98
Copy link
Member

  1. The whole faf system is based on versions

@chrsin
Copy link
Contributor

chrsin commented Oct 23, 2020

  1. You are right. I even looked at the MapBean class and totally missed the version property. Jeez sometimes it just goes too damn fast!
  2. Roger that.

My proposal for a solution would be to check for a new version when the user clicks create. If there is a new version we show a downloading dialog with a description of what is going on. After the download is complete the game is hosted with the new version.

Do we need any kind of automatic updating of maps in the background or is this model good enough? (I'm thinking a new version might change the "minimap picture" and that might result in more downloads.
Any pointers on how to have these background tasks in the client would be much appreciated.

@1-alex98
Copy link
Member

I am unsure what your question is

@chrsin
Copy link
Contributor

chrsin commented Oct 26, 2020

My question is for you to review my proposed solution.

Also, I'm not sure if we need a task in the background of the client that updates the downloaded maps.

@Marc-Spector
Copy link
Collaborator

@chrsin Hi. Is there any progress?

@Sheikah45
Copy link
Member

I do not think any work has been done on this yet

@Marc-Spector
Copy link
Collaborator

:)
Then I will think about how to implement this feature.

@micheljung
Copy link
Member

micheljung commented Jan 5, 2021

I absolutely think that the client should always download the newest version of a certain map. This is one of the main reasons why we did FAForever/db#24

Think mobile phone apps.

For anyone asking "but what if I want to play an outdated version of a map?": You're out of luck, it's the map author's decision how the map should be (again, think mobile phone apps). If you're unhappy with this, create your own version of the map (although I think that FAF shouldn't allow copied maps).

I suggest that the client should update maps in the background.

@micheljung micheljung changed the title notify host that he is playing an outdated map... Automatically update map when hosting a game Jan 6, 2021
@mnooblet
Copy link
Author

nice 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants