Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMM: Disallow watching replays while in queue #2105

Closed
Sheikah45 opened this issue Jan 6, 2021 · 2 comments · Fixed by #2106
Closed

TMM: Disallow watching replays while in queue #2105

Sheikah45 opened this issue Jan 6, 2021 · 2 comments · Fixed by #2106
Labels
Milestone

Comments

@Sheikah45
Copy link
Member

Describe the bug
Players can watch replays while in queue which could cause mayhem when the game launches

To Reproduce
Join queue watch a replay

@Brutus5000
Copy link
Member

Watchin replays while in game lobby was a mich requested feature (there is an experimental feature toggle). Disabling this without choice seems counter intuitive to me.

@Sheikah45
Copy link
Member Author

#1926 only changed the logic for launching replays to allow the replay to start when another game instance was already running. It did not change the logic for joining or hosting a game. Since tmm launches a game later rather than opening a lobby and waiting it is a different situation than what that feature allows.

@Sheikah45 Sheikah45 added this to the v1.4.0 milestone Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants