Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join discord can fail if regkey is out of date #2128

Closed
Axle1975 opened this issue Jan 24, 2021 · 0 comments · Fixed by #2155
Closed

join discord can fail if regkey is out of date #2128

Axle1975 opened this issue Jan 24, 2021 · 0 comments · Fixed by #2155
Milestone
v1.4.1

Comments

@Axle1975
Copy link

downlords-faf-client/src/main/java/com/faforever/client/discord/JoinDiscordEventHandler.java

Line 27 in 3418820

joinViaDiscord(joinUrl);

I don't know why my regkey is out of date, but I assume there might be others with similar problem. Maybe catch the java.io.IOException and fall back to joinViaBrowser
@Sheikah45 Sheikah45 mentioned this issue Feb 20, 2021
Closed
@Sheikah45 Sheikah45 linked a pull request Feb 21, 2021 that will close this issue
Use rpc server to tell discord to join a server #2155
Merged
@Sheikah45 Sheikah45 added this to the v1.4.1 milestone Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1
Development

Successfully merging a pull request may close this issue.

Use rpc server to tell discord to join a server FAForever/downlords-faf-client
2 participants
@Axle1975 @Sheikah45