Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference in translation arguments can break the client #2165

Closed
Sheikah45 opened this issue Feb 26, 2021 · 0 comments · Fixed by #2166
Closed

Difference in translation arguments can break the client #2165

Sheikah45 opened this issue Feb 26, 2021 · 0 comments · Fixed by #2166
Labels
Milestone

Comments

@Sheikah45
Copy link
Member

When there are differences in the translation arguments or an argument itself is translated such as number to nummer it can lead to crashing the Application thread of the client which results in a non-operational client.

Ideally this situation should just catch the error and return the english rather than crashing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant