Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to UFT8 plain text lobby protocol #2176

Closed
Brutus5000 opened this issue Mar 3, 2021 · 4 comments
Closed

Move to UFT8 plain text lobby protocol #2176

Brutus5000 opened this issue Mar 3, 2021 · 4 comments
Assignees
Milestone

Comments

@Brutus5000
Copy link
Member

The lobby server connection on port 8001 uses the UTF16 QString based QDataStream protocol.
But in the future (next server update) port 8002 will offer the protocol via UTF8 plain text.

We should drop QT related stuff wherever we can (and also this prepares for a future websocket protocol).

Questions:

  • How to handle the new port? We can't change the current remote config field for backward compatibility. Add a new one? Or use configured port + 1?
  • Should we try to switch to TLS encrypted TCP? (isn't implemented yet, but Traefik should offer it and we could try)
  • Can the old clients handle unknown fields in the json?
@Sheikah45
Copy link
Member

I think we should add a new field to the config .

When I tested this by adding a new field and parsing with gson it just ignored the unknown field

@Askaholic
Copy link
Collaborator

I think TLS is a good idea.

Also you should consider this new port to be only semi-stable. I might continue to add new ports with additional changes, (like tls if we don’t add it now) and i might want to remove some of the older ones just so we don’t have a million different lobby ports. So maybe fall back to the old port if the new one isn’t available. That way we don’t need to worry so much about breaking people’s clients if they’re still on the second or third newest release.

@Brutus5000 Brutus5000 self-assigned this Mar 4, 2021
@Sheikah45
Copy link
Member

Fixed in #2317

Also don't remove the utf-8 port it is the new default 😅

@Askaholic
Copy link
Collaborator

It won’t be changed at this point. If we add/change more stuff like TLS we’ll just do it on a different port

@Sheikah45 Sheikah45 added this to the 1.6.0 milestone Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants