Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game crashes when matchmaker finds game while game update not done #2245

Closed
Katharsas opened this issue May 21, 2021 · 8 comments · Fixed by #2773
Closed

Game crashes when matchmaker finds game while game update not done #2245

Katharsas opened this issue May 21, 2021 · 8 comments · Fixed by #2773
Labels

Comments

@Katharsas
Copy link
Collaborator

When there is a new game update, and you queue for matchmaker, and the update doesnt fully get applied before the matchmaker starts, the game itself just crashes because its started while its files are updated.

@Katharsas Katharsas added the bug label May 21, 2021
@Katharsas
Copy link
Collaborator Author

Current game files should probably be downloaded at start of client before user can open Play tab.

@Sheikah45
Copy link
Member

Sure although this doesn't help as much when the patch is deployed while users are online

@Sheikah45
Copy link
Member

This is mostly caused by not being able to tell when party members are ready and so requires a change to the server protocol to fix.

@Katharsas
Copy link
Collaborator Author

It seems like the same problem can happen for slow map downloads according to forum.

@Sheikah45
Copy link
Member

Yes it only happens when you are in a party as there is no way for the party leader to know if you are ready or not before launching the game.

@Katharsas
Copy link
Collaborator Author

Katharsas commented Jun 9, 2021

Maybe for the maps, but game updates are a problem for solo players too (and maps would be as well if theyr were slower to download, which can happen). I think in general party invitation acceptance or queue joining should both be delayed until all files are ready.

@Sheikah45
Copy link
Member

forcing it to be during party invitation doesn't really solve the problem as the issue occurs when a patch is released so people would already be in a party when the change happens. The server currently doesn't send any information on what patch a launched game is supposed to run so there is no way to know if you are running the correct version when in queue unfortunately.

@Katharsas
Copy link
Collaborator Author

Katharsas commented Jun 9, 2021

A lot of people (i assume, at least that happened to me) start the client AFTER the patch has already landed and start queueing in TMM in the days or weeks after a patch release. If they didnt start a game before the patch release day, they run into this issue.

A very tiny fraction of people are queuing at the same time as the patch hits. Thats a much harder problem to solve and impatcs a tiny amount of players.

There are really two separate issues here, and the first one is much more important and much easier to fix than the second.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants